Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused mypy ignore #882

Closed
wants to merge 3 commits into from
Closed

Remove unused mypy ignore #882

wants to merge 3 commits into from

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Aug 31, 2023 •
edited
Loading

resolves #883
docs dbt-labs/docs.getdbt.com/#

check yaml...............................................................Passed
check json...........................................(no files to check)Skipped
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
check for case conflicts.................................................Passed
black....................................................................Passed
flake8...................................................................Passed
mypy.....................................................................Failed
- hook id: mypy
- exit code: 1

dbt/adapters/spark/column.py:12: error: Unused "type: ignore" comment  [unused-ignore]
Found 1 error in 1 file (checked 8 source files)

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@Fokko Fokko requested a review from a team as a code owner August 31, 2023 16:28
@Fokko Fokko requested a review from colin-rogers-dbt August 31, 2023 16:28
@cla-bot cla-bot bot added the cla:yes label Aug 31, 2023
@Fokko Fokko changed the title Make the CI happy Remove unused mypy ignore Aug 31, 2023
@dataders
Copy link
Contributor

dataders commented Sep 6, 2023

looks like this change was already done in #880

@dataders dataders closed this Sep 6, 2023
@Fokko Fokko deleted the patch-3 branch September 6, 2023 19:29
@Fokko
Copy link
Contributor Author

Fokko commented Sep 6, 2023

Looks like it, thanks @dataders

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JCZuurmond JCZuurmond JCZuurmond approved these changes

@colin-rogers-dbt colin-rogers-dbt Awaiting requested review from colin-rogers-dbt colin-rogers-dbt is a code owner automatically assigned from dbt-labs/adapters

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ADAP-868] [Bug] Remove unused mypy ignore
3 participants
@Fokko @dataders @JCZuurmond